Alberne commented on code in PR #9138:
URL: https://github.com/apache/seatunnel/pull/9138#discussion_r2037071240
##########
seatunnel-connectors-v2/connector-http/connector-http-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/config/HttpSourceOptions.java:
##########
@@ -27,6 +27,8 @@ public class HttpSourceOptions extends HttpCommonOptions {
public static final boolean DEFAULT_ENABLE_MULTI_LINES = false;
public static final int DEFAULT_CONNECT_TIMEOUT_MS = 6000 * 2;
public static final int DEFAULT_SOCKET_TIMEOUT_MS = 6000 * 10;
+ public static final String PAGE_NUMBER_PAGINATION_TYPE =
"PageNumberPagination";
Review Comment:
using enums instead of constants, done~
> using enum maybe better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
