Alberne commented on code in PR #9138:
URL: https://github.com/apache/seatunnel/pull/9138#discussion_r2036986149


##########
seatunnel-connectors-v2/connector-http/connector-http-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/config/HttpSourceOptions.java:
##########
@@ -66,6 +68,28 @@ public class HttpSourceOptions extends HttpCommonOptions {
     public static final Option<Map<String, String>> PAGEING =
             
Options.key("pageing").mapType().noDefaultValue().withDescription("pageing");
 
+    public static final Option<String> PAGE_TYPE =
+            Options.key("page_type")
+                    .stringType()
+                    .defaultValue(PAGE_NUMBER_PAGINATION_TYPE)
+                    .withDescription(
+                            "this parameter is used to specify the page type 
,or PageNumberPagination if not set"
+                                    + "for example 
PageNumberPagination、CursorPagination");

Review Comment:
   this parameter specifies the pagination type and defaults to 
`PageNumberPagination` if not explicitly set. Valid options include 
`PageNumberPagination` (traditional page-number-based pagination) and 
`CursorPagination` (token-based cursor pagination).
   ---------------------
   That works ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to