Hisoka-X commented on code in PR #8572: URL: https://github.com/apache/seatunnel/pull/8572#discussion_r1944071549
########## docs/zh/connector-v2/sink/HdfsFile.md: ########## @@ -181,10 +182,19 @@ HdfsFile { is_enable_transaction = true } ``` + ### enable_header_write [boolean] 仅在 file_format_type 为 text,csv 时使用。false:不写入表头,true:写入表头。 +### csv_string_quote_mode [string] + +当文件格式为 CSV 时,CSV 的字符串引号模式。 + +- ALL:所有字符串字段都会加引号。 +- MINIMAL:仅为包含特殊字符(如字段分隔符、引号字符或行分隔符字符串中的任何字符)的字段加引号。 +- NONE:从不为字段加引号。当数据中包含分隔符时,打印机会在前面加上转义字符。如果未设置转义字符,则格式验证会抛出异常。 Review Comment: ```suggestion - NONE:从不为字段加引号。当数据中包含分隔符时,输出会在前面加上转义字符。如果未设置转义字符,则格式验证会抛出异常。 ``` ########## docs/en/connector-v2/sink/LocalFile.md: ########## @@ -33,18 +33,18 @@ By default, we use 2PC commit to ensure `exactly-once` ## Options -| Name | Type | Required | Default | Description | -|---------------------------------------|---------|----------|--------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------| -| path | string | yes | - | | -| tmp_path | string | no | /tmp/seatunnel | The result file will write to a tmp path first and then use `mv` to submit tmp dir to target dir. | -| custom_filename | boolean | no | false | Whether you need custom the filename | -| file_name_expression | string | no | "${transactionId}" | Only used when custom_filename is true | -| filename_time_format | string | no | "yyyy.MM.dd" | Only used when custom_filename is true | -| file_format_type | string | no | "csv" | | -| field_delimiter | string | no | '\001' | Only used when file_format_type is text | -| row_delimiter | string | no | "\n" | Only used when file_format_type is text | -| have_partition | boolean | no | false | Whether you need processing partitions. | -| partition_by | array | no | - | Only used then have_partition is true | +gi t| Name | Type | Required | Default | Description | Review Comment: ```suggestion | Name | Type | Required | Default | Description | ``` ########## docs/zh/connector-v2/sink/LocalFile.md: ########## @@ -176,6 +177,14 @@ Sink 插件的常见参数,请参阅 [Sink 常见选项](../sink-common-option 工作簿的表名。 +### csv_string_quote_mode [string] + +当文件格式为 CSV 时,CSV 的字符串引号模式。 + +- ALL:所有字符串字段都会加引号。 +- MINIMAL:仅为包含特殊字符(如字段分隔符、引号字符或行分隔符字符串中的任何字符)的字段加引号。 +- NONE:从不为字段加引号。当数据中包含分隔符时,打印机会在前面加上转义字符。如果未设置转义字符,则格式验证会抛出异常。 Review Comment: ```suggestion - NONE:从不为字段加引号。当数据中包含分隔符时,输出会在前面加上转义字符。如果未设置转义字符,则格式验证会抛出异常。 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org