Hisoka-X commented on code in PR #8572:
URL: https://github.com/apache/seatunnel/pull/8572#discussion_r1926452506
##########
docs/en/connector-v2/sink/S3File.md:
##########
@@ -119,6 +119,7 @@ If write to `csv`, `text` file type, All column will be
string.
| common-options | object | no | -
|
|
| max_rows_in_memory | int | no | -
| Only used when file_format is excel.
|
| sheet_name | string | no | Sheet${Random
number} | Only used when file_format is excel.
|
+| csv_string_quote_mode | string | no | MINIMAL
| Only used when file_format is csv.
|
Review Comment:
```suggestion
| csv_string_quote_mode | enum | no | MINIMAL
| Only used when file_format is csv.
|
```
##########
docs/en/connector-v2/sink/S3File.md:
##########
@@ -503,18 +514,19 @@ Only used when file_format_type is text,csv.false:don't
write header,true:write
### 2.3.0 2022-12-30
-- [BugFix] Fixed the following bugs that failed to write data to files
([3258](https://github.com/apache/seatunnel/pull/3258))
- - When field from upstream is null it will throw NullPointerException
- - Sink columns mapping failed
- - When restore writer from states getting transaction directly failed
+- [BugFix] Fixed the following bugs that failed to write data to
+ files ([3258](https://github.com/apache/seatunnel/pull/3258))
+ - When field from upstream is null it will throw NullPointerException
+ - Sink columns mapping failed
+ - When restore writer from states getting transaction directly failed
- [Feature] Support S3A protocol
([3632](https://github.com/apache/seatunnel/pull/3632))
- - Allow user to add additional hadoop-s3 parameters
- - Allow the use of the s3a protocol
- - Decouple hadoop-aws dependencies
+ - Allow user to add additional hadoop-s3 parameters
+ - Allow the use of the s3a protocol
+ - Decouple hadoop-aws dependencies
- [Improve] Support setting batch size for every file
([3625](https://github.com/apache/seatunnel/pull/3625))
- [Feature]Set S3 AK to optional
([3688](https://github.com/apache/seatunnel/pull/))
### Next version
-- [Improve] Support file compress
([3899](https://github.com/apache/seatunnel/pull/3899))
+- [Improve] Support file compress
([3899](https://github.com/apache/seatunnel/pull/3899))
Review Comment:
Let's delete this part.
##########
docs/zh/connector-v2/sink/HdfsFile.md:
##########
@@ -63,6 +63,7 @@
| kerberos_keytab_path | string | 否 | -
| kerberos 的 keytab 路径
|
| compress_codec | string | 否 | none
| 压缩编解码器
|
| common-options | object | 否 | -
| 接收器插件通用参数，请参阅 [接收器通用选项](../sink-common-options.md) 了解详情
|
+| csv_string_quote_mode | string | 否 | MINIMAL
| 仅在文件格式为 CSV 时使用。
|
Review Comment:
where is it description?
##########
seatunnel-formats/seatunnel-format-csv/src/test/java/org/apache/seatunnel/format/csv/CsvTextFormatSchemaTest.java:
##########
@@ -148,24 +152,37 @@ public void testParse() throws IOException {
.delimiter(",")
.build();
+ CsvSerializationSchema csvSerializationSchemaWithAllQuotes =
+ CsvSerializationSchema.builder()
+ .seaTunnelRowType(seaTunnelRowType)
+
.dateTimeFormatter(Formatter.YYYY_MM_DD_HH_MM_SS_SSSSSS)
+ .delimiter(",")
+ .quoteMode(CsvStringQuoteMode.ALL)
Review Comment:
Please test other option value too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
