magic-fh commented on code in PR #8231:
URL: https://github.com/apache/seatunnel/pull/8231#discussion_r1875517212


##########
seatunnel-connectors-v2/connector-elasticsearch/src/test/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/serialize/ElasticsearchRowSerializerTest.java:
##########
@@ -71,8 +71,6 @@ public void testSerializeUpsert() {
                         + "\"} }\n"
                         + "{ \"doc\" :{\"name\":\""
                         + name
-                        + "\",\"id\":\""
-                        + id

Review Comment:
   Why can't the code of other connectors that haven't been modified pass unit 
test



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to