magic-fh commented on code in PR #8231:
URL: https://github.com/apache/seatunnel/pull/8231#discussion_r1875424427
##########
seatunnel-connectors-v2/connector-elasticsearch/src/test/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/serialize/ElasticsearchRowSerializerTest.java:
##########
@@ -71,8 +71,6 @@ public void testSerializeUpsert() {
+ "\"} }\n"
+ "{ \"doc\" :{\"name\":\""
+ name
- + "\",\"id\":\""
- + id
Review Comment:
Because the primary_keys field has already been assigned an id, there is no
need to specifically indicate the id in the document
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
