corgy-w commented on code in PR #8173:
URL: https://github.com/apache/seatunnel/pull/8173#discussion_r1864082272
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/transform/SeaTunnelTransform.java:
##########
@@ -54,4 +55,8 @@ default SchemaChangeEvent
mapSchemaChangeEvent(SchemaChangeEvent schemaChangeEve
/** call it when Transformer completed */
default void close() {}
+
+ void setMetricsContext(MetricsContext metricsContext);
+
+ MetricsContext getMetricsContext();
Review Comment:
Transform does not seem to need to abstract `MetricsContext` and expose it
through this interface.
##########
seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/common/AbstractSeaTunnelTransform.java:
##########
@@ -37,14 +44,43 @@ public abstract class AbstractSeaTunnelTransform<T, R>
implements SeaTunnelTrans
protected volatile CatalogTable outputCatalogTable;
- public AbstractSeaTunnelTransform(@NonNull CatalogTable inputCatalogTable)
{
- this(inputCatalogTable,
TransformCommonOptions.ROW_ERROR_HANDLE_WAY_OPTION.defaultValue());
+ protected String inputTableName;
+
+ protected String outTableName;
+
+ protected MetricsContext metricsContext;
+
+ protected volatile Counter counter;
Review Comment:
Do not seem to be used
##########
seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/common/AbstractSeaTunnelTransform.java:
##########
@@ -105,4 +141,39 @@ public R transform(SeaTunnelRow row) {
protected abstract TableSchema transformTableSchema();
protected abstract TableIdentifier transformTableIdentifier();
+
+ @Override
+ public void setMetricsContext(MetricsContext metricsContext) {
+ this.metricsContext = metricsContext;
+ }
+
+ @Override
+ public MetricsContext getMetricsContext() {
+ return metricsContext;
+ }
+
+ protected void hazelcastMetric(long size) {
+ if (metricsContext != null) {
+ metricsContext.counter(getTransformMetricName(this)).inc(size);
+ }
+ }
+
+ protected void hazelcastMetric() {
+ if (metricsContext != null) {
+ metricsContext.counter(getTransformMetricName(this)).inc();
+ }
Review Comment:
is more concise and easier to read
```suggestion
hazelcastMetric(1)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
