Hisoka-X commented on code in PR #8173:
URL: https://github.com/apache/seatunnel/pull/8173#discussion_r1909749941
##########
seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/common/AbstractSeaTunnelTransform.java:
##########
@@ -105,4 +142,27 @@ public R transform(SeaTunnelRow row) {
protected abstract TableSchema transformTableSchema();
protected abstract TableIdentifier transformTableIdentifier();
+
+ protected void hazelcastMetric(long size) {
Review Comment:
```suggestion
protected void updateMetric(long size) {
```
##########
seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/common/AbstractCatalogSupportFlatMapTransform.java:
##########
@@ -30,17 +33,17 @@ public abstract class AbstractCatalogSupportFlatMapTransform
extends AbstractSeaTunnelTransform<SeaTunnelRow, List<SeaTunnelRow>>
implements SeaTunnelFlatMapTransform<SeaTunnelRow> {
- public AbstractCatalogSupportFlatMapTransform(@NonNull CatalogTable
inputCatalogTable) {
- super(inputCatalogTable);
- }
-
public AbstractCatalogSupportFlatMapTransform(
- @NonNull CatalogTable inputCatalogTable, ErrorHandleWay
rowErrorHandleWay) {
- super(inputCatalogTable, rowErrorHandleWay);
Review Comment:
where is `rowErrorHandleWay`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
