Hisoka-X commented on code in PR #7218: URL: https://github.com/apache/seatunnel/pull/7218#discussion_r1708405840
########## seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/common/AbstractCatalogSupportTransform.java: ########## @@ -20,18 +20,36 @@ import org.apache.seatunnel.api.table.catalog.CatalogTable; import org.apache.seatunnel.api.table.catalog.TableIdentifier; import org.apache.seatunnel.api.table.catalog.TableSchema; +import org.apache.seatunnel.api.table.type.SeaTunnelRow; +import org.apache.seatunnel.api.table.type.SeaTunnelRowType; +import org.apache.seatunnel.api.transform.SeaTunnelTransform; import lombok.NonNull; -public abstract class AbstractCatalogSupportTransform extends AbstractSeaTunnelTransform { +public abstract class AbstractCatalogSupportTransform implements SeaTunnelTransform<SeaTunnelRow> { protected CatalogTable inputCatalogTable; protected volatile CatalogTable outputCatalogTable; + protected String inputTableName; + protected SeaTunnelRowType inputRowType; Review Comment: 1. Please only keep inputTableName. 2. We can move it to SQLTransform because only it use this field now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org