Hisoka-X commented on code in PR #7218: URL: https://github.com/apache/seatunnel/pull/7218#discussion_r1706947398
########## seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/common/AbstractSeaTunnelTransform.java: ########## @@ -1,51 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 - * (the "License"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package org.apache.seatunnel.transform.common; Review Comment: yes we can remove this. ########## seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/sql/SQLTransform.java: ########## @@ -70,22 +69,6 @@ public SQLTransform(@NonNull ReadonlyConfig config, @NonNull CatalogTable catalo } else { this.engineType = ZETA; } - - List<String> sourceTableNames = config.get(CommonOptions.SOURCE_TABLE_NAME); - if (sourceTableNames != null && !sourceTableNames.isEmpty()) { - this.inputTableName = sourceTableNames.get(0); - } else { - this.inputTableName = catalogTable.getTableId().getTableName(); - } Review Comment: we should keep this at now. The logs displayed by the two different names will be slightly different. ########## seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/sql/SQLTransform.java: ########## @@ -97,9 +80,9 @@ public String getPluginName() { public void open() { sqlEngine = SQLEngineFactory.getSQLEngine(engineType); sqlEngine.init( - inputTableName, Review Comment: ditto ########## seatunnel-dist/src/main/assembly/assembly-bin-ci.xml: ########## @@ -140,14 +140,15 @@ <scope>provided</scope> </dependencySet> - <!-- ============ Connectors Jars ============ --> + <!-- ============ Connectors Jars And Transforms V2 Jar ============ --> <!-- SeaTunnel connectors --> <dependencySet> <useProjectArtifact>false</useProjectArtifact> <useTransitiveDependencies>true</useTransitiveDependencies> <unpack>false</unpack> <includes> <include>org.apache.seatunnel:connector-*:jar</include> + <include>org.apache.seatunnel:seatunnel-transforms-v2:jar</include> Review Comment: PTAL. @hailin0 @EricJoy2048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
