Re: [PR] [Improve][Connector-v2] Optimize the count table rows for jdbc-oracle and oracle-cdc [seatunnel]

[via GitHub]

dailai commented on code in PR #7248:
URL: https://github.com/apache/seatunnel/pull/7248#discussion_r1690611233


##########
docs/en/connector-v2/source/Oracle-CDC.md:
##########
@@ -270,6 +272,44 @@ source {
 }
 ```
 
+> Use the select count(*) instead of analysis table for count table rows in 
full stage
+>
+> ```conf
+> source {
+> # This is a example source plugin **only for test and demonstrate the 
feature source plugin**
+> Oracle-CDC {
+> result_table_name = "customers"
+> use_select_count = true 
+> username = "system"
+> password = "oracle"
+> database-names = ["XE"]
+> schema-names = ["DEBEZIUM"]
+> table-names = ["XE.DEBEZIUM.FULL_TYPES"]
+> base-url = "jdbc:oracle:thin:system/oracle@oracle-host:1521:xe"
+> source.reader.close.timeout = 120000
+> }
+> }
+> ```
+>
+> Use the select NUM_ROWS from all_tables for the table rows but skip the 
analyze table.
+>
+> ```conf
+> source {
+> # This is a example source plugin **only for test and demonstrate the 
feature source plugin**
+> Oracle-CDC {
+> result_table_name = "customers"
+> skip_analyze = true 
+> username = "system"
+> password = "oracle"
+> database-names = ["XE"]
+> schema-names = ["DEBEZIUM"]
+> table-names = ["XE.DEBEZIUM.FULL_TYPES"]
+> base-url = "jdbc:oracle:thin:system/oracle@oracle-host:1521:xe"
+> source.reader.close.timeout = 120000

Review Comment:
   > @dailai
   > 
   > `source.reader.close.timeout`
   
   This was already there, I didn't add it, I just added two options. And it 
does have this property.
   
![image](https://github.com/user-attachments/assets/fb3124bb-6268-4564-ac7f-6c41dc8bd4cd)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org