dailai commented on code in PR #7248:
URL: https://github.com/apache/seatunnel/pull/7248#discussion_r1689277289
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/config/JdbcSourceOptions.java:
##########
@@ -93,4 +93,16 @@ public interface JdbcSourceOptions {
+ "The value represents the denominator of
the sampling rate fraction. "
+ "For example, a value of 1000 means a
sampling rate of 1/1000. "
+ "This parameter is used when the sample
sharding strategy is triggered.");
+
+ Option<Boolean> USE_SELECT_COUNT =
+ Options.key("use_select_count")
+ .booleanType()
+ .defaultValue(false)
Review Comment:
> Do we need to enable it by default？
In my opinion, the default behavior should not be changed, and this property
should be enabled when needed. Analyze table is faster than select count in
some cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
