EricJoy2048 commented on code in PR #6062:
URL: https://github.com/apache/seatunnel/pull/6062#discussion_r1435923473
##########
seatunnel-examples/seatunnel-engine-examples/pom.xml:
##########
@@ -29,6 +29,9 @@
<properties>
<hadoop3.version>3.1.4</hadoop3.version>
+ <hadoop-aliyun.version>3.1.4</hadoop-aliyun.version>
Review Comment:
> Whether it needs to appear in example？
Thanks, I will roll back it.
##########
seatunnel-dist/pom.xml:
##########
@@ -636,12 +636,6 @@
</dependency>
<!-- hadoop jar -->
- <dependency>
- <groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-aliyun</artifactId>
- <version>${hadoop-aliyun.version}</version>
- <scope>provided</scope>
- </dependency>
Review Comment:
Because it's repetitive. In the line 665 we already have `hadoop-aliyun`.
##########
seatunnel-connectors-v2/connector-file/connector-file-local/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/local/sink/LocalFileSinkFactory.java:
##########
@@ -17,32 +17,25 @@
package org.apache.seatunnel.connectors.seatunnel.file.local.sink;
-import org.apache.seatunnel.shade.com.typesafe.config.Config;
-import org.apache.seatunnel.shade.com.typesafe.config.ConfigValueFactory;
-
import org.apache.seatunnel.api.configuration.ReadonlyConfig;
import org.apache.seatunnel.api.configuration.util.OptionRule;
-import org.apache.seatunnel.api.sink.SinkReplaceNameConstant;
import org.apache.seatunnel.api.table.catalog.CatalogTable;
-import org.apache.seatunnel.api.table.catalog.TableIdentifier;
import org.apache.seatunnel.api.table.connector.TableSink;
import org.apache.seatunnel.api.table.factory.Factory;
-import org.apache.seatunnel.api.table.factory.TableSinkFactory;
import org.apache.seatunnel.api.table.factory.TableSinkFactoryContext;
import org.apache.seatunnel.api.table.type.SeaTunnelRow;
import org.apache.seatunnel.connectors.seatunnel.file.config.BaseSinkConfig;
import org.apache.seatunnel.connectors.seatunnel.file.config.FileFormat;
import org.apache.seatunnel.connectors.seatunnel.file.config.FileSystemType;
+import
org.apache.seatunnel.connectors.seatunnel.file.factory.BaseMultipleTableFinkSinkFactory;
import
org.apache.seatunnel.connectors.seatunnel.file.sink.commit.FileAggregatedCommitInfo;
import
org.apache.seatunnel.connectors.seatunnel.file.sink.commit.FileCommitInfo;
import org.apache.seatunnel.connectors.seatunnel.file.sink.state.FileSinkState;
import com.google.auto.service.AutoService;
@AutoService(Factory.class)
-public class LocalFileSinkFactory
- implements TableSinkFactory<
- SeaTunnelRow, FileSinkState, FileCommitInfo,
FileAggregatedCommitInfo> {
+public class LocalFileSinkFactory extends BaseMultipleTableFinkSinkFactory {
Review Comment:
> Is this change related to oss?
While adding multi-table support for oss, I found that
`BaseMultipleTableFinkSinkFactory` could be added to make the code cleaner, so
I needed to modify the `LocalFileSinkFactory` implementation
##########
seatunnel-examples/seatunnel-engine-examples/pom.xml:
##########
@@ -29,6 +29,9 @@
<properties>
<hadoop3.version>3.1.4</hadoop3.version>
+ <hadoop-aliyun.version>3.1.4</hadoop-aliyun.version>
Review Comment:
done
##########
seatunnel-connectors-v2/connector-file/connector-file-local/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/local/sink/LocalFileSinkFactory.java:
##########
@@ -17,32 +17,25 @@
package org.apache.seatunnel.connectors.seatunnel.file.local.sink;
-import org.apache.seatunnel.shade.com.typesafe.config.Config;
-import org.apache.seatunnel.shade.com.typesafe.config.ConfigValueFactory;
-
import org.apache.seatunnel.api.configuration.ReadonlyConfig;
import org.apache.seatunnel.api.configuration.util.OptionRule;
-import org.apache.seatunnel.api.sink.SinkReplaceNameConstant;
import org.apache.seatunnel.api.table.catalog.CatalogTable;
-import org.apache.seatunnel.api.table.catalog.TableIdentifier;
import org.apache.seatunnel.api.table.connector.TableSink;
import org.apache.seatunnel.api.table.factory.Factory;
-import org.apache.seatunnel.api.table.factory.TableSinkFactory;
import org.apache.seatunnel.api.table.factory.TableSinkFactoryContext;
import org.apache.seatunnel.api.table.type.SeaTunnelRow;
import org.apache.seatunnel.connectors.seatunnel.file.config.BaseSinkConfig;
import org.apache.seatunnel.connectors.seatunnel.file.config.FileFormat;
import org.apache.seatunnel.connectors.seatunnel.file.config.FileSystemType;
+import
org.apache.seatunnel.connectors.seatunnel.file.factory.BaseMultipleTableFinkSinkFactory;
import
org.apache.seatunnel.connectors.seatunnel.file.sink.commit.FileAggregatedCommitInfo;
import
org.apache.seatunnel.connectors.seatunnel.file.sink.commit.FileCommitInfo;
import org.apache.seatunnel.connectors.seatunnel.file.sink.state.FileSinkState;
import com.google.auto.service.AutoService;
@AutoService(Factory.class)
-public class LocalFileSinkFactory
- implements TableSinkFactory<
- SeaTunnelRow, FileSinkState, FileCommitInfo,
FileAggregatedCommitInfo> {
+public class LocalFileSinkFactory extends BaseMultipleTableFinkSinkFactory {
Review Comment:
> Is this change related to oss?
While adding multi-table support for oss, I found that
`BaseMultipleTableFinkSinkFactory` could be added to make the code cleaner, so
I needed to modify the `LocalFileSinkFactory` implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
