hailin0 commented on code in PR #6062: URL: https://github.com/apache/seatunnel/pull/6062#discussion_r1435849724
########## seatunnel-e2e/seatunnel-connector-v2-e2e/connector-file-oss-e2e/src/test/resources/excel/fake_to_oss_excel.conf: ########## @@ -0,0 +1,77 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +env { + execution.parallelism = 1 Review Comment: ```suggestion parallelism = 1 ``` change all execution.parallelism to parallelism https://github.com/apache/seatunnel/pull/6003 ########## seatunnel-dist/pom.xml: ########## @@ -636,12 +636,6 @@ </dependency> <!-- hadoop jar --> - <dependency> - <groupId>org.apache.hadoop</groupId> - <artifactId>hadoop-aliyun</artifactId> - <version>${hadoop-aliyun.version}</version> - <scope>provided</scope> - </dependency> Review Comment: why delete it ########## seatunnel-connectors-v2/connector-file/connector-file-local/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/local/sink/LocalFileSinkFactory.java: ########## @@ -17,32 +17,25 @@ package org.apache.seatunnel.connectors.seatunnel.file.local.sink; -import org.apache.seatunnel.shade.com.typesafe.config.Config; -import org.apache.seatunnel.shade.com.typesafe.config.ConfigValueFactory; - import org.apache.seatunnel.api.configuration.ReadonlyConfig; import org.apache.seatunnel.api.configuration.util.OptionRule; -import org.apache.seatunnel.api.sink.SinkReplaceNameConstant; import org.apache.seatunnel.api.table.catalog.CatalogTable; -import org.apache.seatunnel.api.table.catalog.TableIdentifier; import org.apache.seatunnel.api.table.connector.TableSink; import org.apache.seatunnel.api.table.factory.Factory; -import org.apache.seatunnel.api.table.factory.TableSinkFactory; import org.apache.seatunnel.api.table.factory.TableSinkFactoryContext; import org.apache.seatunnel.api.table.type.SeaTunnelRow; import org.apache.seatunnel.connectors.seatunnel.file.config.BaseSinkConfig; import org.apache.seatunnel.connectors.seatunnel.file.config.FileFormat; import org.apache.seatunnel.connectors.seatunnel.file.config.FileSystemType; +import org.apache.seatunnel.connectors.seatunnel.file.factory.BaseMultipleTableFinkSinkFactory; import org.apache.seatunnel.connectors.seatunnel.file.sink.commit.FileAggregatedCommitInfo; import org.apache.seatunnel.connectors.seatunnel.file.sink.commit.FileCommitInfo; import org.apache.seatunnel.connectors.seatunnel.file.sink.state.FileSinkState; import com.google.auto.service.AutoService; @AutoService(Factory.class) -public class LocalFileSinkFactory - implements TableSinkFactory< - SeaTunnelRow, FileSinkState, FileCommitInfo, FileAggregatedCommitInfo> { +public class LocalFileSinkFactory extends BaseMultipleTableFinkSinkFactory { Review Comment: Is this change related to oss? ########## docs/en/connector-v2/source/OssFile.md: ########## @@ -293,6 +293,177 @@ sink { } ``` +### Multiple Table + +No need to config schema file type, eg: `orc`. + +``` +env { + execution.parallelism = 1 Review Comment: ```suggestion parallelism = 1 ``` ########## docs/en/connector-v2/sink/OssFile.md: ########## @@ -362,6 +362,123 @@ sink { } ``` +### Multiple Table + +For extract source metadata from upstream, you can use `${database_name}`, `${table_name}` and `${schema_name}` in the path. + +```bash + +env { + execution.parallelism = 1 Review Comment: ```suggestion parallelism = 1 ``` ########## docs/en/connector-v2/sink/OssFile.md: ########## @@ -362,6 +362,123 @@ sink { } ``` +### Multiple Table + +For extract source metadata from upstream, you can use `${database_name}`, `${table_name}` and `${schema_name}` in the path. + +```bash + +env { + execution.parallelism = 1 Review Comment: https://github.com/apache/seatunnel/pull/6003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
