Hisoka-X commented on code in PR #5782:
URL: https://github.com/apache/seatunnel/pull/5782#discussion_r1382749469
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/catalog/DataTypeConvertor.java:
##########
@@ -28,34 +28,39 @@ public interface DataTypeConvertor<T> {
/**
* Transfer the data type from connector to SeaTunnel.
*
+ * @param field The field name of the column
* @param connectorDataType e.g. "int", "varchar(255)"
* @return the data type of SeaTunnel
*/
- SeaTunnelDataType<?> toSeaTunnelType(String connectorDataType);
+ SeaTunnelDataType<?> toSeaTunnelType(String field, String
connectorDataType);
Review Comment:
I think add new method is unnecessary. Because the `DataTypeConvertor` never
be used in 2.3.3. So We can change it before 2.3.4 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
