hailin0 commented on code in PR #5782:
URL: https://github.com/apache/seatunnel/pull/5782#discussion_r1382747850
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/catalog/DataTypeConvertor.java:
##########
@@ -28,34 +28,39 @@ public interface DataTypeConvertor<T> {
/**
* Transfer the data type from connector to SeaTunnel.
*
+ * @param field The field name of the column
* @param connectorDataType e.g. "int", "varchar(255)"
* @return the data type of SeaTunnel
*/
- SeaTunnelDataType<?> toSeaTunnelType(String connectorDataType);
+ SeaTunnelDataType<?> toSeaTunnelType(String field, String
connectorDataType);
/**
* Transfer the data type from connector to SeaTunnel.
*
+ * @param field The field name of the column
* @param connectorDataType origin data type
* @param dataTypeProperties origin data type properties, e.g. precision,
scale, length
* @return SeaTunnel data type
*/
// todo: If the origin data type contains the properties, we can remove
the dataTypeProperties.
SeaTunnelDataType<?> toSeaTunnelType(
- T connectorDataType, Map<String, Object> dataTypeProperties)
+ String field, T connectorDataType, Map<String, Object>
dataTypeProperties)
Review Comment:
same
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/catalog/DataTypeConvertor.java:
##########
@@ -28,34 +28,39 @@ public interface DataTypeConvertor<T> {
/**
* Transfer the data type from connector to SeaTunnel.
*
+ * @param field The field name of the column
* @param connectorDataType e.g. "int", "varchar(255)"
* @return the data type of SeaTunnel
*/
- SeaTunnelDataType<?> toSeaTunnelType(String connectorDataType);
+ SeaTunnelDataType<?> toSeaTunnelType(String field, String
connectorDataType);
Review Comment:
add new method ？
```suggestion
SeaTunnelDataType<?> toSeaTunnelType(String connectorDataType);
SeaTunnelDataType<?> toSeaTunnelType(String field, String
connectorDataType);
```
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/catalog/DataTypeConvertor.java:
##########
@@ -28,34 +28,39 @@ public interface DataTypeConvertor<T> {
/**
* Transfer the data type from connector to SeaTunnel.
*
+ * @param field The field name of the column
* @param connectorDataType e.g. "int", "varchar(255)"
* @return the data type of SeaTunnel
*/
- SeaTunnelDataType<?> toSeaTunnelType(String connectorDataType);
+ SeaTunnelDataType<?> toSeaTunnelType(String field, String
connectorDataType);
Review Comment:
add new method ？
```suggestion
SeaTunnelDataType<?> toSeaTunnelType(String connectorDataType);
SeaTunnelDataType<?> toSeaTunnelType(String field, String
connectorDataType);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
