The GitHub Actions job "CI" on rocketmq-dashboard.git/codex/ai-tab-reader-guard 
has succeeded.
Run started by GitHub user iloveeyjafjalla (triggered by iloveeyjafjalla).

Head commit for run:
fc633e6f121b020b89765fca206a153878040ca0 / iloveeyjafjalla <[email protected]>
fix(web): guard the data source and cloud credential writes for readers

The AI tab is not the only settings tab whose writes are admin-only: the data 
source and cloud
credential tabs offer add, edit, delete and (for data sources) a connection 
test to every role
while every one of those endpoints falls through to the admin requirement in 
AuthInterceptor.
A reader's click could only come back 403.

Both tabs now derive the same role check the general settings tab uses and 
apply it the same
way: the controls are disabled, the handlers return early and the modals' OK 
button is
disabled too. The reader test file covers all three tabs on both sides of the 
role.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/39388403474

With regards,
GitHub Actions via GitBox

Reply via email to