The GitHub Actions job "CI" on rocketmq-dashboard.git/codex/ai-tab-reader-guard 
has succeeded.
Run started by GitHub user iloveeyjafjalla (triggered by iloveeyjafjalla).

Head commit for run:
b9c662a0b41b7ba308dcf82b1fae0c52188b795e / iloveeyjafjalla <[email protected]>
fix(web): keep a reader out of the AI settings writes

The AI assistant tab offers save, test-connection and clear-key to every role, 
while the
endpoints behind them are admin-only on both ends: GET /api/llm/config is an 
admin-only read
(the tab's own load-error comment says a reader always lands there) and POST
/api/llm/config falls through to the admin requirement in AuthInterceptor. A 
reader's click
can therefore only produce a 403.

The general settings tab was given exactly this guard for the writes it owns
(GeneralSettingsTab.canWriteSettings, applied to five buttons and every write 
handler); the
AI tab now derives the same role check, disables the three controls and returns 
early in the
three handlers, so the two tabs of one page agree about who may write.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/38870758303

With regards,
GitHub Actions via GitBox

Reply via email to