lizhimins opened a new issue, #4309:
URL: https://github.com/apache/rocketmq-dashboard/issues/4309

   ### Motivation
   
   `rmqctl` resolves the instance a command operates on from the surrounding 
context and config rather than from an explicit flag. Four problems follow:
   
   - **Silent mistargeting.** Because a value is injected when the user does 
not supply one, a command can run against an instance the operator never named. 
For write operations (`topic.update`, `group.delete`, `group.reset_offset`) 
that is the difference between a no-op and data loss, and nothing in the 
invocation records which instance was chosen. This contradicts 
`docs/studio-instance-model-spec.md`, which requires `instanceId` to be an 
explicit required parameter with no default injection, and which the server 
side now enforces via `x-rmq-instance-id`.
   - **Stale catalog client.** The generated catalog client still describes the 
old tool surface, so it does not match the 40-tool catalog the server exposes.
   - **Unknown schema keywords pass silently.** The generator still carries 
`x-target-mode` and tolerates unrecognized keywords, so a typo or a removed 
extension in the catalog YAML produces a client that quietly drops information 
instead of failing generation.
   - **`reset_offset` cannot express "now".** The timestamp is required but 
there is no supported way to ask for the current time, so the tool cannot be 
driven non-interactively.
   
   ### Expected
   
   - replace the context-derived cluster with a **required** `--instance-id` 
flag, sent as `x-rmq-instance-id` and passed through to the tool arguments, 
with no value injected from the context or config
   - regenerate the catalog client for the 40-tool surface, and drop 
`x-target-mode` from the generator so an unknown schema keyword fails generation
   - fill a required reset-offset timestamp from `x-client-default: NOW`
   - recompute the HMAC golden vectors for the renamed canonical payload


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to