lizhimins opened a new pull request, #4310:
URL: https://github.com/apache/rocketmq-dashboard/pull/4310

   Closes #4309
   
   - replace the context-derived cluster with a required `--instance-id` flag, 
sent as `x-rmq-instance-id` and passed through to the tool arguments; no value 
is injected from the context or config
   - regenerate the catalog client for the 40-tool surface and drop 
`x-target-mode` from the generator, so an unknown schema keyword now fails 
generation
   - fill a required reset-offset timestamp from `x-client-default: NOW`
   - recompute the HMAC golden vectors for the renamed canonical payload
   
   This is the CLI half of the same change the server made in #4308: the 
instance is named by the operator on every invocation instead of being 
inferred, so a write command cannot silently land on an instance the operator 
never mentioned. Making the flag required rather than defaulting it is 
deliberate — `docs/studio-instance-model-spec.md` rules out default injection 
for `instanceId`.
   
   33 files, +1475/−716. `catalog_gen.go` is regenerated from the tool YAML 
shards (the generated docs under `docs/generated/` are local build artifacts 
and are not committed), `testdata/auth-hmac-vectors.json` carries the 
recomputed golden vectors, and `mcp_message_test.go`/`tools_test.go` cover the 
header plumbing and the NOW default.
   
   Note for reviewers: this machine has no Go toolchain, so `go build`/`go 
vet`/`go test ./...` were not run locally for this PR — they were green on the 
equivalent tree before the catalog was split out for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to