unbridled-41 commented on PR #3997:
URL:
https://github.com/apache/rocketmq-dashboard/pull/3997#issuecomment-5570786698
Thanks @lizhimins — all three blocking points are reworked in 7f080fc6
(branch also re-based onto current `rocketmq-studio` f5519e87 via merge so the
shared classifier/provider state matches what you reviewed):
1. **Moved to the navigation-visible broker table.** The
`pages/studio/BrokerCluster.tsx` change is dropped entirely (you're right that
its route has no menu entry). The four columns now render on the Broker 管理 tab
table in `pages/cluster/index.tsx` — the one users actually see — after TPS
Out, with the page's existing column conventions.
2. **Shared daily-delta helper.** `parseDailyMessageDelta` is gone. The
algorithm now lives once as `BrokerRuntimeStats.dailyCounterDelta(table,
morningKey, nowKey)` in `common/util`, next to `outboundTps`;
`RocketMQClusterProvider` calls it for the four counters and
`RocketMQDashboardProvider#parseMessagesToday` was deleted in favor of the same
call, so the two copies can't drift.
3. **Table conventions.** Every new column declares `width` (120) and the
table's `scroll={{ x: tableScrollX(brokerColumns) }}` picks them up
automatically — no hardcoded scroll value.
Tests: `RocketMQClusterProviderTest` 18/18 (counter parsing cases),
`BrokerRuntimeStatsTest` 7/7 (new helper cases: subtraction, restart-reset
clamp, missing/negative/unparseable → 0), `ClusterRepositoryImplTest` 5/5
(defensive-copy preservation), `RocketMQDashboardProviderTest` 30/30 (provider
whose private parser was replaced), combined 60/60. Frontend:
`ClusterPage.test.tsx` 25/25 including a new test asserting the counters and
localized headers render in the broker tab; reverted studio suite still 15/15;
`tsc --noEmit` and `eslint` clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
