unbridled-41 commented on PR #3997:
URL:
https://github.com/apache/rocketmq-dashboard/pull/3997#issuecomment-5558001552
## Verification evidence
- **CI**: head `a5ebab5c154793ff02d2dc78881f7c9b7f4e2fe9` has 0 check runs
and no workflow runs (verified via `commits/{sha}/check-runs` and
`actions/runs?head_sha`); upstream CI currently fails to start for all
branches, so results come from local execution.
- **Red (before the fix)**: implementation stashed, tests kept — server `mvn
test-compile`: `invalid method reference / cannot find symbol` ×4
(`BrokerVO::getPutMessagesToday`, `getPutMessagesYesterday`,
`getGetMessagesToday`, `getGetMessagesYesterday`); web `npx vitest run -t
"daily message counters"`: `TestingLibraryElementError: Unable to find an
element with the text: 1,234` (1 failed, 15 skipped).
- **Module tests**: `mvn -ntp test -Dtest=RocketMQClusterProviderTest` →
Tests run: 17, Failures: 0, Errors: 0. Web: `npx vitest run
src/pages/studio/__tests__/BrokerCluster.test.tsx` → 16 passed (16).
- **Full suites + baseline**: backend `mvn -ntp clean test` → 2037 tests, 3
failures — the pristine baseline set of 36126024 (AuthCorsIntegrationTest ×2,
AliyunInstanceProviderTest.getGroupProgressShouldMapLagRowsTest); 2037 = 2035 +
2 new tests, zero new failures. Web `npx vitest run` → 923 tests, 2 failures,
both in the untouched `ConsumerPage.test.tsx` (documented load fragility; the
file passes 29/29 in isolation); 923 = 922 + 1 new test.
- **Build**: `npm run build` succeeds (vite ✓); `npx tsc -b` clean; `eslint`
clean on the changed web files. Backend compiled as part of `mvn test`.
- **Diff self-check**: 7 files, +143/−0 — BrokerVO (+4 fields),
RocketMQClusterProvider (+parsing helper + 4 builder calls), 1 server test file
(+2 tests), web type (+4 optional fields), topology page (+4 columns + record
mapping + export columns), i18n (+4 keys), 1 web test file (+1 test, fixture
values). No unrelated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
