RockteMQ-AI commented on code in PR #3999:
URL:
https://github.com/apache/rocketmq-dashboard/pull/3999#discussion_r3943571267
##########
server/src/main/java/org/apache/rocketmq/studio/provider/apache/RocketMQDLQProvider.java:
##########
@@ -405,6 +407,10 @@ private DLQMessageVO toExportVO(MessageExt message) {
.body(toUtf8Text(message.getBody()))
.bodyBase64(message.getBody() == null ? null
:
Base64.getEncoder().encodeToString(message.getBody()))
+ .properties(limitProperties(message.getProperties()))
Review Comment:
Minor performance: `limitProperties(message.getProperties())` is called
twice in `toExportVO()` — once for `.properties()` and once inside
`.propertiesTruncated()`. Consider computing it once into a local variable and
reusing it to avoid redundant sorting and stream operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
