unbridled-41 commented on PR #3999:
URL:
https://github.com/apache/rocketmq-dashboard/pull/3999#issuecomment-5558347112
## Verification evidence
- **CI**: head `f77c10a2c4b9dfbc539f361b8405cea2eebabf04` has 0 check runs
and no workflow runs (verified via `commits/{sha}/check-runs` and
`actions/runs?head_sha`); upstream CI currently fails to start for all
branches, so results come from local execution.
- **Red (before the fix)**: implementation stashed, tests kept — server `mvn
test-compile`: `cannot find symbol` ×4 (`DLQMessageVO.getProperties()`,
`isPropertiesTruncated()` and the test-side accessors); web `npx vitest run
src/pages/instance/__tests__/DLQPage.test.tsx -t "user properties"`:
`TestingLibraryElementError: Unable to find an accessible element with the role
"button" and name /expand/i` (1 failed, 18 skipped).
- **Module tests**: `mvn -ntp test -Dtest=RocketMQDLQProviderTest` → Tests
run: 34, Failures: 0, Errors: 0 (32 pre-existing + 2 new). Web: `npx vitest run
src/pages/instance/__tests__/DLQPage.test.tsx` → 19 passed (19).
- **Full suites + baseline**: backend `mvn -ntp clean test` → 2037 tests, 3
failures — byte-identical to the pristine baseline of 36126024
(AuthCorsIntegrationTest ×2,
AliyunInstanceProviderTest.getGroupProgressShouldMapLagRowsTest); 2037 = 2035 +
2 new tests, zero new failures. Web `npx vitest run` → 923 tests, 5 failures,
all in untouched files (ClusterPage ×1, ConsumerPage ×3, TopicPage ×1) while
the backend suite ran in parallel; those four files pass 91/91 in isolation
once the load clears (documented load fragility); 923 = 922 + 1 new test.
- **Build**: `npm run build` succeeds (vite ✓); `npx tsc -b` clean; `eslint`
clean on the changed files — the single warning on `dlq.tsx:81`
(`react-refresh/only-export-components`) exists on the pristine base too
(verified by stashing this PR's changes and re-running).
- **Diff self-check**: 6 files, +166/−0 — DLQMessageVO (+2 fields),
RocketMQDLQProvider (+2 constants, +3 helpers, 2 builder calls), 1 server test
file (+2 tests), web type (+2 optional fields), DLQ drawer (+expandable rows),
1 web test file (+1 test). No unrelated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
