lizhanhui commented on issue #8924: URL: https://github.com/apache/rocketmq/issues/8924#issuecomment-2476002598
1. It's reasonable to have this method raise Exception if it cannot accomplish its job and does not have enough knowledge to handle the failure properly; 2. MessageStore cannot always be successful; 3. If your Magic MessageStore Implementation is capable of being always successful, your job to adapt to this change should be trivial, catch and throw a runtime one or silent it; 4. This is not a public API change beyond broker role, aka, this change does not affect clients, admin tools, etc. 5. If you guys are worried, why not keep an eye on the pull request earlier, the pull request stayed open for several days; -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
