lizhimins commented on issue #8924: URL: https://github.com/apache/rocketmq/issues/8924#issuecomment-2478245120
1. Change an existing method beheavier violates the open closed principle. Moreover, if getMaxOffset method is modified, getMinOffset should also be correspondingly adjusted. Additionally, mixing the LMQ handling logic into the existing logic without proper abstraction is not elegant. 2. It is reasonable to pay attention to and discuss this commit before the next release. As is well known, it may cost months for a Linux kernal fix to be merged into the mainline. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
