lizhanhui commented on code in PR #8830:
URL: https://github.com/apache/rocketmq/pull/8830#discussion_r1805799504


##########
store/src/main/java/org/apache/rocketmq/store/rocksdb/RocksDBOptionsFactory.java:
##########
@@ -71,7 +71,7 @@ public static ColumnFamilyOptions createCQCFOptions(final 
MessageStore messageSt
                 setTableFormatConfig(blockBasedTableConfig).
                 setMemTableConfig(new SkipListMemTableConfig()).
                 setCompressionType(CompressionType.LZ4_COMPRESSION).
-                setBottommostCompressionType(CompressionType.ZSTD_COMPRESSION).
+                setBottommostCompressionType(CompressionType.LZ4_COMPRESSION).

Review Comment:
   OK, let's parameterize this option; However, I prefer to let it default to 
an option that makes more sense instead of keeping it unchanged. Will this 
preference make sense for you? @fuyou001 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to