lizhanhui commented on code in PR #8830:
URL: https://github.com/apache/rocketmq/pull/8830#discussion_r1805794010
##########
store/src/main/java/org/apache/rocketmq/store/rocksdb/RocksDBOptionsFactory.java:
##########
@@ -71,7 +71,7 @@ public static ColumnFamilyOptions createCQCFOptions(final
MessageStore messageSt
setTableFormatConfig(blockBasedTableConfig).
setMemTableConfig(new SkipListMemTableConfig()).
setCompressionType(CompressionType.LZ4_COMPRESSION).
- setBottommostCompressionType(CompressionType.ZSTD_COMPRESSION).
+ setBottommostCompressionType(CompressionType.LZ4_COMPRESSION).
Review Comment:
Column Family for CQ uses Universal Compaction, implying each SST will
compact to last level. Unlike level compaction where ZSTD makes sense because
it achieves better compression ratio at cost of more CPU usage.
LZ4 achieves more balanced CPU/compression ratio, thus is a better fit for
universal compaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
