Stephanie0002 opened a new pull request, #8212:
URL: https://github.com/apache/rocketmq/pull/8212

   <!-- Please make sure the target branch is right. In most case, the target 
branch should be `develop`. -->
   
   ### Which Issue(s) This PR Fixes
   
   <!-- Please ensure that the related issue has already been created, and 
[link this pull request to that issue using 
keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>)
 to ensure automatic closure. -->
   
   Fixes #8211 
   
   ### Brief Description
   
   <!-- Write a brief description for your pull request to help the maintainer 
understand the reasons behind your changes. -->
   Add two metrics rocketmq_create_topic_time and 
rocketmq_create_subscription_time as following: 
   
   | Type      | Name                                   | Unit        | 
Description                                                                     
                                                                                
                                                                                
                                                | Label                         
                                    |
   | --------- | -------------------------------------- | ----------- 
|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
 ----------------------------------------------------------------- |
   | histogram | rocketmq_create_topic_time             | millisecond | The 
topic creation time: <br />le_10_ms<br />le_100_ms<br />le_1_s<br />le_3_s<br 
/>le_5_s<br />le_overflow                                                       
                                                                                
                                              | 
node_id,request_is_success,is_system                            |
   | histogram | rocketmq_create_subscription_time      | millisecond | The 
subscription group creation time: <br />le_10_ms<br />le_100_ms<br />le_1_s<br 
/>le_3_s<br />le_5_s<br />le_overflow                                           
                                                                                
                                             | node_id,request_is_success       
                               |
   
   ### How Did You Test This Change?
   
   <!-- In order to ensure the code quality of Apache RocketMQ, we expect every 
pull request to have undergone thorough testing. -->
   
   Simplified Testing Strategy
   1. Modify the `metricsExporterType` within the `brokerConfig` to `PROM`, 
which will export data in Prometheus format.
   ...
   ```java
   private MetricsExporterType metricsExporterType = MetricsExporterType.PROM;
   ...
   private int metricsPromExporterPort = 5557;
   private String metricsPromExporterHost = "127.0.0.1";
   ...
   ```
   2. Initiate both the broker and nameserver processes.
   3. Execute the following command in the local terminal: `curl 
localhost:<export_port>` (default is `5557`), then verify that the output 
metrics align with expectations.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to