caigy commented on code in PR #200:
URL: https://github.com/apache/rocketmq-operator/pull/200#discussion_r1434686925


##########
example/rocketmq_v1alpha1_rocketmq_cluster.yaml:
##########
@@ -78,6 +92,12 @@ spec:
         items:
           - key: broker-common.conf
             path: broker-common.conf
+#          - key: plain_acl.yml
+#            path: plain_acl.yml
+#  volumeMounts:
+#    - name: broker-config
+#      subPath: plain_acl.yml
+#      mountPath: /root/rocketmq/broker/conf/plain_acl.yml

Review Comment:
   IMO users should not care about the path of configuration files, operator 
should mount the correct path for it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to