drivebyer commented on code in PR #200:
URL: https://github.com/apache/rocketmq-operator/pull/200#discussion_r1435930532
##########
example/rocketmq_v1alpha1_rocketmq_cluster.yaml:
##########
@@ -78,6 +92,12 @@ spec:
items:
- key: broker-common.conf
path: broker-common.conf
+# - key: plain_acl.yml
+# path: plain_acl.yml
+# volumeMounts:
+# - name: broker-config
+# subPath: plain_acl.yml
+# mountPath: /root/rocketmq/broker/conf/plain_acl.yml
Review Comment:
I agree, how about support custom volume in this pr(#192), raise another pr
to support #184 ?
To support #184 , user may only need to input two thing:
1. `plain_acl.yml` in broker-config configmap like `broker-common.conf`
2. volumes like
https://github.com/apache/rocketmq-operator/blob/d5e797b10d9c3e9275da715486b302365b7681ff/example/rocketmq_v1alpha1_rocketmq_cluster.yaml#L75-L80
```
- name: broker-config
configMap:
name: broker-config
items:
- key: broker-common.conf
path: broker-common.conf
- key: plain_acl.yml
path: plain_acl.yml
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
