lizhimins commented on code in PR #7488:
URL: https://github.com/apache/rocketmq/pull/7488#discussion_r1373995525


##########
store/src/main/java/org/apache/rocketmq/store/timer/TimerMessageStore.java:
##########
@@ -291,6 +291,19 @@ public void recover() {
         }
         currQueueOffset = Math.min(currQueueOffset, 
timerCheckpoint.getMasterTimerQueueOffset());
 
+        ConsumeQueueInterface cq = 
this.messageStore.getConsumeQueue(TIMER_TOPIC, 0);
+
+        // Correction based consume queue
+        if (cq != null && currQueueOffset < cq.getMinOffsetInQueue()) {

Review Comment:
   currQueueOffset < cq.getMinOffsetInQueue() 这个情况什么时候出现,应该比较少吧



##########
store/src/main/java/org/apache/rocketmq/store/timer/TimerMessageStore.java:
##########
@@ -291,6 +291,19 @@ public void recover() {
         }
         currQueueOffset = Math.min(currQueueOffset, 
timerCheckpoint.getMasterTimerQueueOffset());
 
+        ConsumeQueueInterface cq = 
this.messageStore.getConsumeQueue(TIMER_TOPIC, 0);
+
+        // Correction based consume queue
+        if (cq != null && currQueueOffset < cq.getMinOffsetInQueue()) {

Review Comment:
   currQueueOffset < cq.getMinOffsetInQueue() 这个情况什么时候出现,应该比较少吧



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to