[GitHub] [rocketmq] xiaoyifang commented on issue #5720: [code smell] System.currentTimeMillis() is a static method ,wrap it as a class method is inconvenient.

GitBox Sat, 17 Dec 2022 00:43:25 -0800


xiaoyifang commented on issue #5720:
URL: https://github.com/apache/rocketmq/issues/5720#issuecomment-1356123006


   > It is inappropriate to use `System.currentTimeMillis()` in 
TimerMessageStore
   
   this  can be set as a new issue to deal with.     
   
   > it would be of great help to our test
   
   test friendly is really a good aspect to concern.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

[GitHub] [rocketmq] xiaoyifang commented on issue #5720: [code smell] System.currentTimeMillis() is a static method ,wrap it as a class method is inconvenient.

Reply via email to