[GitHub] [rocketmq] xiaoyifang opened a new issue, #5720: [code smell] System.currentTimeMillis() is a static method ,wrap it with a class method is inconvenient.

Fri, 16 Dec 2022 02:06:05 -0800 


xiaoyifang opened a new issue, #5720:
URL: https://github.com/apache/rocketmq/issues/5720

   
https://github.com/apache/rocketmq/blob/81e3648e3fcb1995897db3960a4561d6047b696c/common/src/main/java/org/apache/rocketmq/common/SystemClock.java#L19-L22
   
   In order to use SystemClock's now method , one has to define SystemClock 
class instance first ,then use as
   
   `this.systemClock.now()`
   
   suggest to replace the `now` method with a static method 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to