Copilot commented on code in PR #24790:
URL: https://github.com/apache/pulsar/pull/24790#discussion_r2383946443
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientBuilderImpl.java:
##########
@@ -43,7 +44,9 @@
import org.apache.pulsar.common.util.DefaultPulsarSslFactory;
public class ClientBuilderImpl implements ClientBuilder {
+ private static final long serialVersionUID = 1L;
Review Comment:
Adding serialVersionUID to a class that wasn't previously serializable may
indicate a breaking change. Ensure this change is intentional and consider the
impact on existing serialized instances.
```suggestion
```
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientSharedResourcesImpl.java:
##########
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.client.impl;
+
+import static
org.apache.pulsar.client.impl.PulsarClientResourcesConfigurer.createDnsResolverGroupWithResourceConfig;
+import static
org.apache.pulsar.client.impl.PulsarClientResourcesConfigurer.createEventLoopGroupWithResourceConfig;
+import static
org.apache.pulsar.client.impl.PulsarClientResourcesConfigurer.createExternalExecutorProviderWithResourceConfig;
+import static
org.apache.pulsar.client.impl.PulsarClientResourcesConfigurer.createInternalExecutorProviderWithResourceConfig;
+import static
org.apache.pulsar.client.impl.PulsarClientResourcesConfigurer.createLookupExecutorProviderWithResourceConfig;
+import static
org.apache.pulsar.client.impl.PulsarClientResourcesConfigurer.createScheduledExecutorProviderWithResourceConfig;
+import static
org.apache.pulsar.client.impl.PulsarClientResourcesConfigurer.createTimer;
+import io.netty.channel.EventLoopGroup;
+import io.netty.util.Timer;
+import java.util.Collection;
+import java.util.EnumSet;
+import java.util.Map;
+import java.util.Set;
+import lombok.Getter;
+import org.apache.pulsar.client.api.PulsarClientException;
+import org.apache.pulsar.client.api.PulsarClientSharedResources;
+import org.apache.pulsar.client.util.ExecutorProvider;
+import org.apache.pulsar.client.util.ScheduledExecutorProvider;
+import org.apache.pulsar.common.util.netty.EventLoopUtil;
+
+@Getter
+public class PulsarClientSharedResourcesImpl implements
PulsarClientSharedResources {
+ Set<SharedResource> sharedResources;
+ protected final EventLoopGroup ioEventLoopGroup;
+ private final ExecutorProvider internalExecutorProvider;
+ private final ExecutorProvider externalExecutorProvider;
+ private final ScheduledExecutorProvider scheduledExecutorProvider;
+ private final Timer timer;
+ private final ExecutorProvider lookupExecutorProvider;
+ private final DnsResolverGroupImpl dnsResolverGroup;
+
+ public PulsarClientSharedResourcesImpl(Set<SharedResource> sharedResources,
+ Map<SharedResource,
PulsarClientSharedResourcesBuilderImpl.ResourceConfig>
+ resourceConfigs) {
+ if (sharedResources.isEmpty()) {
+ this.sharedResources = EnumSet.allOf(SharedResource.class);
+ } else {
+ this.sharedResources = Set.copyOf(sharedResources);
+ }
+ if (this.sharedResources.contains(SharedResource.DnsResolver)
+ && !this.sharedResources.contains(SharedResource.EventLoopGroup)) {
+ throw new IllegalArgumentException(
+ "It's necessary to enable ResourceType.eventLoopGroup when
using ResourceType.dnsResolverGroup");
+ }
+ this.ioEventLoopGroup =
this.sharedResources.contains(SharedResource.EventLoopGroup)
+ ? createEventLoopGroupWithResourceConfig(
+ getResourceConfig(resourceConfigs,
SharedResource.EventLoopGroup))
+ : null;
+ this.externalExecutorProvider =
this.sharedResources.contains(SharedResource.ListenerExecutor)
+ ? createExternalExecutorProviderWithResourceConfig(
+ getResourceConfig(resourceConfigs,
SharedResource.ListenerExecutor))
+ : null;
+ this.internalExecutorProvider =
this.sharedResources.contains(SharedResource.InternalExecutor)
+ ? createInternalExecutorProviderWithResourceConfig(
+ getResourceConfig(resourceConfigs,
SharedResource.InternalExecutor))
+ : null;
+ this.scheduledExecutorProvider =
this.sharedResources.contains(SharedResource.ScheduledExecutor)
+ ? createScheduledExecutorProviderWithResourceConfig(
+ getResourceConfig(resourceConfigs,
SharedResource.ScheduledExecutor))
+ : null;
+ this.lookupExecutorProvider =
this.sharedResources.contains(SharedResource.LookupExecutor)
+ ? createLookupExecutorProviderWithResourceConfig(
+ getResourceConfig(resourceConfigs,
SharedResource.LookupExecutor))
+ : null;
+ this.timer = this.sharedResources.contains(SharedResource.Timer)
+ ? createTimer(getResourceConfig(resourceConfigs,
SharedResource.Timer))
+ : null;
+ this.dnsResolverGroup =
this.sharedResources.contains(SharedResource.DnsResolver)
+ ? createDnsResolverGroupWithResourceConfig(
+ getResourceConfig(resourceConfigs,
SharedResource.DnsResolver),
+ ioEventLoopGroup)
+ : null;
+ }
+
+ private <T extends PulsarClientSharedResourcesBuilderImpl.ResourceConfig>
T getResourceConfig(
+ Map<SharedResource,
PulsarClientSharedResourcesBuilderImpl.ResourceConfig> resourceConfigs,
+ SharedResource resource) {
+ return (T) resourceConfigs.get(resource);
Review Comment:
The unchecked cast should be avoided. Consider using a type-safe approach
with proper generics or add a @SuppressWarnings annotation with justification.
```suggestion
getResourceConfig(resourceConfigs,
SharedResource.EventLoopGroup,
PulsarClientSharedResourcesBuilderImpl.EventLoopGroupResourceConfig.class))
: null;
this.externalExecutorProvider =
this.sharedResources.contains(SharedResource.ListenerExecutor)
? createExternalExecutorProviderWithResourceConfig(
getResourceConfig(resourceConfigs,
SharedResource.ListenerExecutor,
PulsarClientSharedResourcesBuilderImpl.ExternalExecutorResourceConfig.class))
: null;
this.internalExecutorProvider =
this.sharedResources.contains(SharedResource.InternalExecutor)
? createInternalExecutorProviderWithResourceConfig(
getResourceConfig(resourceConfigs,
SharedResource.InternalExecutor,
PulsarClientSharedResourcesBuilderImpl.InternalExecutorResourceConfig.class))
: null;
this.scheduledExecutorProvider =
this.sharedResources.contains(SharedResource.ScheduledExecutor)
? createScheduledExecutorProviderWithResourceConfig(
getResourceConfig(resourceConfigs,
SharedResource.ScheduledExecutor,
PulsarClientSharedResourcesBuilderImpl.ScheduledExecutorResourceConfig.class))
: null;
this.lookupExecutorProvider =
this.sharedResources.contains(SharedResource.LookupExecutor)
? createLookupExecutorProviderWithResourceConfig(
getResourceConfig(resourceConfigs,
SharedResource.LookupExecutor,
PulsarClientSharedResourcesBuilderImpl.LookupExecutorResourceConfig.class))
: null;
this.timer = this.sharedResources.contains(SharedResource.Timer)
? createTimer(getResourceConfig(resourceConfigs,
SharedResource.Timer,
PulsarClientSharedResourcesBuilderImpl.TimerResourceConfig.class))
: null;
this.dnsResolverGroup =
this.sharedResources.contains(SharedResource.DnsResolver)
? createDnsResolverGroupWithResourceConfig(
getResourceConfig(resourceConfigs,
SharedResource.DnsResolver,
PulsarClientSharedResourcesBuilderImpl.DnsResolverResourceConfig.class),
ioEventLoopGroup)
: null;
}
private <T extends
PulsarClientSharedResourcesBuilderImpl.ResourceConfig> T getResourceConfig(
Map<SharedResource,
PulsarClientSharedResourcesBuilderImpl.ResourceConfig> resourceConfigs,
SharedResource resource,
Class<T> clazz) {
PulsarClientSharedResourcesBuilderImpl.ResourceConfig config =
resourceConfigs.get(resource);
if (config == null) {
return null;
}
if (!clazz.isInstance(config)) {
throw new IllegalArgumentException("Resource config for " +
resource + " is not of type " + clazz.getName());
}
return clazz.cast(config);
```
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientSharedResourcesBuilderImpl.java:
##########
@@ -0,0 +1,192 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.client.impl;
+
+import java.net.InetSocketAddress;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.TimeUnit;
+import java.util.function.Consumer;
+import org.apache.pulsar.client.api.PulsarClientSharedResources;
+import org.apache.pulsar.client.api.PulsarClientSharedResourcesBuilder;
+
+public class PulsarClientSharedResourcesBuilderImpl implements
PulsarClientSharedResourcesBuilder {
+ Set<PulsarClientSharedResources.SharedResource> sharedResources = new
HashSet<>();
+ Map<PulsarClientSharedResources.SharedResource, ResourceConfig>
resourceConfigs = new HashMap<>();
+
+ interface ResourceConfig {
+
+ }
+
+ abstract static class NamedResourceConfig<T> implements ResourceConfig {
+ String name;
+
+ public T name(String name) {
+ this.name = name;
+ return (T) this;
+ }
+ }
+
+ static class ThreadPoolResourceConfig extends
NamedResourceConfig<ThreadPoolConfig> implements ThreadPoolConfig {
+ int numberOfThreads = Runtime.getRuntime().availableProcessors();
+ boolean daemon = Thread.currentThread().isDaemon();
+
+ @Override
+ public ThreadPoolConfig numberOfThreads(int numberOfThreads) {
+ this.numberOfThreads = numberOfThreads;
+ return this;
+ }
+
+ @Override
+ public ThreadPoolConfig daemon(boolean daemon) {
+ this.daemon = daemon;
+ return this;
+ }
+ }
+
+ static class EventLoopResourceConfig extends
NamedResourceConfig<EventLoopGroupConfig>
+ implements EventLoopGroupConfig {
+ int numberOfThreads = Runtime.getRuntime().availableProcessors();
+ boolean daemon = Thread.currentThread().isDaemon();
+ boolean enableBusyWait;
+
+ EventLoopResourceConfig() {
+ name = PulsarClientResourcesConfigurer.POOL_NAME_EVENT_LOOP_GROUP;
+ }
+
+ @Override
+ public EventLoopGroupConfig numberOfThreads(int numberOfThreads) {
+ this.numberOfThreads = numberOfThreads;
+ return this;
+ }
+
+ @Override
+ public EventLoopGroupConfig daemon(boolean daemon) {
+ this.daemon = daemon;
+ return this;
+ }
+
+ @Override
+ public EventLoopGroupConfig enableBusyWait(boolean enableBusyWait) {
+ this.enableBusyWait = enableBusyWait;
+ return this;
+ }
+ }
+
+ static class TimerResourceConfig extends NamedResourceConfig<TimerConfig>
implements TimerConfig {
+ long tickDuration = 1L;
+ TimeUnit tickDurationTimeUnit = TimeUnit.MILLISECONDS;
+
+ TimerResourceConfig() {
+ name = PulsarClientResourcesConfigurer.NAME_TIMER;
+ }
+
+ @Override
+ public TimerConfig tickDuration(long tickDuration, TimeUnit timeUnit) {
+ this.tickDuration = tickDuration;
+ this.tickDurationTimeUnit = timeUnit;
+ return this;
+ }
+ }
+
+ static class DnsResolverResourceConfig implements ResourceConfig,
DnsResolverConfig {
+ InetSocketAddress bindAddress;
+ Collection<InetSocketAddress> serverAddresses;
+
+ @Override
+ public DnsResolverConfig bindAddress(InetSocketAddress bindAddress) {
+ this.bindAddress = bindAddress;
+ return this;
+ }
+
+ @Override
+ public DnsResolverConfig serverAddresses(Collection<InetSocketAddress>
addresses) {
+ this.serverAddresses = List.copyOf(addresses);
+ return this;
+ }
+ }
+
+ @Override
+ public PulsarClientSharedResourcesBuilder resourceTypes(
+ PulsarClientSharedResources.SharedResource... sharedResource) {
+ return resourceTypes(List.of(sharedResource));
+ }
+
+ @Override
+ public PulsarClientSharedResourcesBuilder resourceTypes(
+ Collection<PulsarClientSharedResources.SharedResource>
sharedResource) {
+ sharedResources.addAll(sharedResource);
+ return this;
+ }
+
+ private <T extends ResourceConfig> T
getOrCreateConfig(PulsarClientSharedResources.SharedResource sharedResource) {
+ return (T) resourceConfigs.computeIfAbsent(sharedResource, k -> {
+ switch (sharedResource.getType()) {
+ case EventLoopGroup:
+ return new EventLoopResourceConfig();
+ case DnsResolver:
+ return new DnsResolverResourceConfig();
+ case ThreadPool:
+ return new ThreadPoolResourceConfig();
+ case Timer:
+ return new TimerResourceConfig();
+ default:
+ throw new IllegalArgumentException("Unknown resource type:
" + sharedResource.getType());
+ }
+ });
+ }
Review Comment:
The unchecked cast should be avoided. Consider using a type-safe approach
with proper generics or add a @SuppressWarnings annotation with justification.
```suggestion
/**
```
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientSharedResourcesBuilderImpl.java:
##########
@@ -0,0 +1,192 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.client.impl;
+
+import java.net.InetSocketAddress;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.TimeUnit;
+import java.util.function.Consumer;
+import org.apache.pulsar.client.api.PulsarClientSharedResources;
+import org.apache.pulsar.client.api.PulsarClientSharedResourcesBuilder;
+
+public class PulsarClientSharedResourcesBuilderImpl implements
PulsarClientSharedResourcesBuilder {
+ Set<PulsarClientSharedResources.SharedResource> sharedResources = new
HashSet<>();
+ Map<PulsarClientSharedResources.SharedResource, ResourceConfig>
resourceConfigs = new HashMap<>();
+
+ interface ResourceConfig {
+
+ }
+
+ abstract static class NamedResourceConfig<T> implements ResourceConfig {
+ String name;
+
+ public T name(String name) {
Review Comment:
The unchecked cast `(T) this` is potentially unsafe. Consider using bounded
type parameters or method overrides in subclasses to avoid the unchecked cast
warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
