codecov-commenter commented on PR #24790: URL: https://github.com/apache/pulsar/pull/24790#issuecomment-3340160392
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/24790?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `82.23350%` with `35 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 74.24%. Comparing base ([`1050f48`](https://app.codecov.io/gh/apache/pulsar/commit/1050f48035c97a14094b812467f046f6d37ff6f4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4791e48`](https://app.codecov.io/gh/apache/pulsar/commit/4791e48b54f7059e9de2a9b929ce0f958b807fb1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/pulsar/pull/24790?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...r/client/impl/PulsarClientSharedResourcesImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/24790?src=pr&el=tree&filepath=pulsar-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fclient%2Fimpl%2FPulsarClientSharedResourcesImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL1B1bHNhckNsaWVudFNoYXJlZFJlc291cmNlc0ltcGwuamF2YQ==) | 65.57% | [4 Missing and 17 partials :warning: ](https://app.codecov.io/gh/apache/pulsar/pull/24790?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...t/impl/PulsarClientSharedResourcesBuilderImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/24790?src=pr&el=tree&filepath=pulsar-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fclient%2Fimpl%2FPulsarClientSharedResourcesBuilderImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL1B1bHNhckNsaWVudFNoYXJlZFJlc291cmNlc0J1aWxkZXJJbXBsLmphdmE=) | 77.58% | [11 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/pulsar/pull/24790?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [...r/client/impl/PulsarClientResourcesConfigurer.java](https://app.codecov.io/gh/apache/pulsar/pull/24790?src=pr&el=tree&filepath=pulsar-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fclient%2Fimpl%2FPulsarClientResourcesConfigurer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL1B1bHNhckNsaWVudFJlc291cmNlc0NvbmZpZ3VyZXIuamF2YQ==) | 97.22% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/pulsar/pull/24790?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/pulsar/pull/24790?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #24790 +/- ## ============================================= + Coverage 38.67% 74.24% +35.57% - Complexity 13237 33370 +20133 ============================================= Files 1850 1911 +61 Lines 144540 148887 +4347 Branches 16763 17268 +505 ============================================= + Hits 55895 110546 +54651 + Misses 81156 29516 -51640 - Partials 7489 8825 +1336 ``` | [Flag](https://app.codecov.io/gh/apache/pulsar/pull/24790/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [inttests](https://app.codecov.io/gh/apache/pulsar/pull/24790/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `26.52% <13.70%> (-0.17%)` | :arrow_down: | | [systests](https://app.codecov.io/gh/apache/pulsar/pull/24790/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `22.74% <13.70%> (-0.07%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/pulsar/pull/24790/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.78% <82.23%> (+38.90%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/apache/pulsar/pull/24790?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...pulsar/client/api/PulsarClientSharedResources.java](https://app.codecov.io/gh/apache/pulsar/pull/24790?src=pr&el=tree&filepath=pulsar-client-api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fclient%2Fapi%2FPulsarClientSharedResources.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9jbGllbnQvYXBpL1B1bHNhckNsaWVudFNoYXJlZFJlc291cmNlcy5qYXZh) | `100.00% <100.00%> (ø)` | | | [...nt/internal/PulsarClientImplementationBinding.java](https://app.codecov.io/gh/apache/pulsar/pull/24790?src=pr&el=tree&filepath=pulsar-client-api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fclient%2Finternal%2FPulsarClientImplementationBinding.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9jbGllbnQvaW50ZXJuYWwvUHVsc2FyQ2xpZW50SW1wbGVtZW50YXRpb25CaW5kaW5nLmphdmE=) | `62.50% <ø> (+12.50%)` | :arrow_up: | | [...g/apache/pulsar/client/impl/ClientBuilderImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/24790?src=pr&el=tree&filepath=pulsar-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fclient%2Fimpl%2FClientBuilderImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL0NsaWVudEJ1aWxkZXJJbXBsLmphdmE=) | `86.95% <100.00%> (+55.13%)` | :arrow_up: | | [...rg/apache/pulsar/client/impl/PulsarClientImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/24790?src=pr&el=tree&filepath=pulsar-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fclient%2Fimpl%2FPulsarClientImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL1B1bHNhckNsaWVudEltcGwuamF2YQ==) | `76.00% <100.00%> (+17.21%)` | :arrow_up: | | [...nt/impl/PulsarClientImplementationBindingImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/24790?src=pr&el=tree&filepath=pulsar-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fclient%2Fimpl%2FPulsarClientImplementationBindingImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL1B1bHNhckNsaWVudEltcGxlbWVudGF0aW9uQmluZGluZ0ltcGwuamF2YQ==) | `80.30% <100.00%> (+26.45%)` | :arrow_up: | | [...rg/apache/pulsar/client/util/ExecutorProvider.java](https://app.codecov.io/gh/apache/pulsar/pull/24790?src=pr&el=tree&filepath=pulsar-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fclient%2Futil%2FExecutorProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC91dGlsL0V4ZWN1dG9yUHJvdmlkZXIuamF2YQ==) | `66.66% <100.00%> (+4.16%)` | :arrow_up: | | [.../pulsar/client/util/ScheduledExecutorProvider.java](https://app.codecov.io/gh/apache/pulsar/pull/24790?src=pr&el=tree&filepath=pulsar-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fclient%2Futil%2FScheduledExecutorProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC91dGlsL1NjaGVkdWxlZEV4ZWN1dG9yUHJvdmlkZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | | | [...r/client/impl/PulsarClientResourcesConfigurer.java](https://app.codecov.io/gh/apache/pulsar/pull/24790?src=pr&el=tree&filepath=pulsar-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fclient%2Fimpl%2FPulsarClientResourcesConfigurer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL1B1bHNhckNsaWVudFJlc291cmNlc0NvbmZpZ3VyZXIuamF2YQ==) | `97.22% <97.22%> (ø)` | | | [...t/impl/PulsarClientSharedResourcesBuilderImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/24790?src=pr&el=tree&filepath=pulsar-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fclient%2Fimpl%2FPulsarClientSharedResourcesBuilderImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL1B1bHNhckNsaWVudFNoYXJlZFJlc291cmNlc0J1aWxkZXJJbXBsLmphdmE=) | `77.58% <77.58%> (ø)` | | | [...r/client/impl/PulsarClientSharedResourcesImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/24790?src=pr&el=tree&filepath=pulsar-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fclient%2Fimpl%2FPulsarClientSharedResourcesImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL1B1bHNhckNsaWVudFNoYXJlZFJlc291cmNlc0ltcGwuamF2YQ==) | `65.57% <65.57%> (ø)` | | ... and [1404 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/24790/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
