BewareMyPower commented on code in PR #24714:
URL: https://github.com/apache/pulsar/pull/24714#discussion_r2331828221
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/AuthorizationService.java:
##########
@@ -219,7 +219,7 @@ public CompletableFuture<Boolean> canProduceAsync(TopicName
topicName, String ro
if (!this.conf.isAuthorizationEnabled()) {
return CompletableFuture.completedFuture(true);
}
- return provider.isSuperUser(role, authenticationData,
conf).thenComposeAsync(isSuperUser -> {
+ return provider.isSuperUser(role, authenticationData,
conf).thenCompose(isSuperUser -> {
Review Comment:
> I would assume that the implementer of the interface should implement the
async semantics,
It never makes sense to assume the implementation from 3rd party libraries
has a certain behavior. There could be a chance that the downstream application
has implemented a blocking method and it works well.
Now you changed the way of upstream side for how to call this API and you
have to clarify that their implementation is now illegal though it has been
working for long time.
That's what is called "breaking change".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
