oneby-wang commented on code in PR #24714:
URL: https://github.com/apache/pulsar/pull/24714#discussion_r2331849966
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/AuthorizationService.java:
##########
@@ -219,7 +219,7 @@ public CompletableFuture<Boolean> canProduceAsync(TopicName
topicName, String ro
if (!this.conf.isAuthorizationEnabled()) {
return CompletableFuture.completedFuture(true);
}
- return provider.isSuperUser(role, authenticationData,
conf).thenComposeAsync(isSuperUser -> {
+ return provider.isSuperUser(role, authenticationData,
conf).thenCompose(isSuperUser -> {
Review Comment:
I got your point, but I see many direct calls to AuthorizationProvider in
AuthorizationService, without wrapping a thenXxxAsync method. How do we
guarantee non-blocking behaviour of these calls in that case?
Or we are just talking about "don't break change in existed non-blocking
behaviours"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
