lhotari commented on PR #24346: URL: https://github.com/apache/pulsar/pull/24346#issuecomment-3074935712
@BewareMyPower > Performing read operations concurrently could increase the CPU pressure from Pulsar side, because there will be more inflight requests. Pulsar has a setting managedLedgerMaxReadsInFlightSizeInMB which serves as back pressure for inflight requests. > In addition, this PR is merged with no tests added. It's very risky from my perspective. I didn't look into the details at the moment, but not sure if it could affect the calling order of original `readEntriesComplete` callbacks. I will take a look soon. The existing test coverage covers the functional testing of these changes. Reviewing PRs in a timely manner is important for keeping our contributors engaged. Hopefully more Pulsar committers will pay attention to PRs going forward. This PR has a clear argumentation and is good quality. I hope we receive more of these going forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
