LivingLikeKrillin commented on PR #2597: URL: https://github.com/apache/plc4x/pull/2597#issuecomment-4801230403
Thanks for taking the time to check it out and for wiring up the generated-driver test run — much appreciated. Good catch on the `deviceCode` representation. I actually ran into the exact same thing while building the driver on my (separate, stacked) branch, and had already converted the test vectors to the canonical enum form (`<SlmpDeviceCode … stringRepresentation="D">168</SlmpDeviceCode>`). I've just pushed that fix to this PR, so no need to send yours — but thank you for the offer. On the bigger picture: this PR is intentionally the protocol-only module (mspec + generated wire layer), which is why the test suite isn't exercised here yet. The Java driver that actually runs these vectors is the next, separate PR, stacked on top of this one — I'll open it once this merges so its diff stays clean. Happy to adjust if you'd prefer different sequencing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
