chrisdutz commented on PR #2597:
URL: https://github.com/apache/plc4x/pull/2597#issuecomment-4797366854
I've checked out your PR and created a dummy slmp driver module where the
code is generated from your mspec and added a ParserSerializerTest to use the
generated code with your xml ... I had to set it to fix one general issue: in
your initial XML you had "deviceCode" modelled as:
` <deviceCode>D</deviceCode>
`
However it's an enum with a numerical value, so correct would be:
```
<deviceCode>
<SlmpDeviceCode dataType="uint" bitLength="8"
stringRepresentation="D">168</SlmpDeviceCode>
</deviceCode>
```
This was the only issue I found in getting the driver's types, parsers and
serializers generated and the test-suite running.
You want me to send you my changes or do you want to learn it yourself?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
