andvasp commented on PR #2382:
URL: https://github.com/apache/plc4x/pull/2382#issuecomment-4694687249
Hi @chrisdutz,
I have completed the initial tests for this refactoring using the
HelloPlc4xRead example from plc4x-extras. I compared the develop branch after
the merge (commit e0950449) against the version before the merge (commit
a495bbf9).
Here are the results:
OPC UA: Working on both versions.
EIP: Working on both versions.
AB-ETH: Works on the old version, but fails on the new one.
S7: Works on the old version, but fails on the new one.
I will investigating further.
Notes & Issues:
EIP Tags: I am having trouble reading certain tags in both versions, even
though they can be read successfully from the OPC Server.
Debug Logs: I noticed that the old version displayed detailed debug-level
logs (see below). This no longer seems to happen. Has this behavior changed?
╔═S7Message═════════════════════════════════════════════════════════════════════════════════════════════════════════╗
║╔═protocolId╗╔═messageType╗╔═reserved╗╔═tpduReference╗╔═parameterLength╗╔═payloadLength╗╔═S7MessageResponseData═══╗║
║║ 0x32 50 ║║ 0x03 3 ║║0x0000 0 ║║ 0x000b 11 ║║ 0x0002 2 ║║
0x0006 6 ║║╔═errorClass╗╔═errorCode╗║║
║╚═══════════╝╚════════════╝╚═════════╝╚══════════════╝╚════════════════╝╚══════════════╝║║
0x00 0 ║║ 0x00 0 ║║║
║
║╚═══════════╝╚══════════╝║║
║
╚═════════════════════════╝║
║╔═parameter/S7Parameter═══════════════════════════════════╗
║
║║╔═parameterType╗╔═S7ParameterReadVarResponse/numItems═══╗║
║
║║║ 0x04 4 ║║ 0x01 1 ║║
║
║║╚══════════════╝╚═══════════════════════════════════════╝║
║
║╚═════════════════════════════════════════════════════════╝
║
║╔═payload/S7Payload/S7PayloadReadVarResponse/items/S7VarPayloadDataItem═════════════════════════════╗
║
║║╔═returnCode/DataTransportErrorCode════════════╗╔═transportSize/DataTransportSize════╗╔═dataLength╗║
║
║║║ 0xff 255 OK ║║ 0x05 5 INTEGER
║║ 0x0010 16 ║║ ║
║║╚══════════════════════════════════════════════╝╚════════════════════════════════════╝╚═══════════╝║
║
║║╔═data═══════════════════════════════════════╗
║ ║
║║║0|02 a8 '.. '║
║ ║
║║╚════════════════════════════════════════════╝
║ ║
║╚═══════════════════════════════════════════════════════════════════════════════════════════════════╝
║
╚═══════════════════════════════════════════════════════════════════════════════════════════════════════════════════╝
Best regards,
Anderson
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
