andvasp commented on PR #2382: URL: https://github.com/apache/plc4x/pull/2382#issuecomment-4690513274
> > Did you check out the branch and build the entire project? I did move the locations of the driver classes.. But if you bike the full project it should work. > > Chris > > Yes, the entire project builds successfully. However, I am also testing other drivers and ran into an issue. > > The ServiceLoader is throwing an exception because the class path listed in [s7/META-INF/services](https://github.com/apache/plc4x/blob/refactor/spi3/plc4j/drivers/s7/src/main/resources/META-INF/services/org.apache.plc4x.java.api.PlcDriver) is incorrect. To fix it locally, I had to modify the mapping: > > **From**: org.apache.plc4x.java.s7.**readwrite**.S7Driver (does not exist) **To:** org.apache.plc4x.java.s7.~readwrite~.S7Driver > > It seems either the META-INF/services file is pointing to the wrong package, or the readwrite.S7Driver class was accidentally left out of the repository. > > Could you please check which one is correct? Once iI know I can continue my tests for s7 PLC. > > Thanks, Anderson. Hi @chrisdutz , Did you have a chance to check my comment above? Maybe I am missing something. Thank you, Anderson. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
