SabrinaZhaozyf commented on code in PR #14430:
URL: https://github.com/apache/pinot/pull/14430#discussion_r1839102597
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java:
##########
@@ -180,6 +181,24 @@ private void initInstanceDataDir(File instanceDataDir) {
}
}
+ @Override
+ public List<File> getConsumerDirPaths() {
+ String consumerDirPath = _instanceDataManagerConfig.getConsumerDir();
+
+ if (consumerDirPath != null) {
+ return Collections.singletonList(new File(consumerDirPath));
+ } else {
+ List<File> consumerDirs = new ArrayList<>();
+ String instanceDataDir = _instanceDataManagerConfig.getInstanceDataDir();
+ for (String tableNameWithType : getAllTables()) {
+ String dirPath = instanceDataDir + File.separator + tableNameWithType
+ File.separator
Review Comment:
It will not count offline table dataDir size as the directory will not
exist. Latest commit explicitly checks instance type tho, which should make it
clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
