vvivekiyer commented on code in PR #14430:
URL: https://github.com/apache/pinot/pull/14430#discussion_r1838747910
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java:
##########
@@ -180,6 +181,24 @@ private void initInstanceDataDir(File instanceDataDir) {
}
}
+ @Override
+ public List<File> getConsumerDirPaths() {
+ String consumerDirPath = _instanceDataManagerConfig.getConsumerDir();
+
+ if (consumerDirPath != null) {
+ return Collections.singletonList(new File(consumerDirPath));
+ } else {
+ List<File> consumerDirs = new ArrayList<>();
+ String instanceDataDir = _instanceDataManagerConfig.getInstanceDataDir();
+ for (String tableNameWithType : getAllTables()) {
+ String dirPath = instanceDataDir + File.separator + tableNameWithType
+ File.separator
Review Comment:
Will this also end up considering offline tables? Do we want to just do this
for realtime tables ? If we are doing this for all tables, then it might just
be enough to calculate the size of instanceDataDir?
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java:
##########
@@ -180,6 +181,24 @@ private void initInstanceDataDir(File instanceDataDir) {
}
}
+ @Override
+ public List<File> getConsumerDirPaths() {
+ String consumerDirPath = _instanceDataManagerConfig.getConsumerDir();
+
+ if (consumerDirPath != null) {
+ return Collections.singletonList(new File(consumerDirPath));
+ } else {
+ List<File> consumerDirs = new ArrayList<>();
Review Comment:
This code block is repeating the logic in
RealtimeTableDataManager.getConsumerDir right? Can we move that logic to a
common place and reuse from both places?
Duplicating logic can result in the metrics breaking if this logic changes
in`RealtimeTableDataManager.getConsumerDir`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
