mcvsubbu commented on code in PR #13803:
URL: https://github.com/apache/pinot/pull/13803#discussion_r1719842646
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java:
##########
@@ -103,12 +104,14 @@ public class PinotRealtimeTableResource {
@ApiOperation(value = "Pause consumption of a realtime table", notes =
"Pause the consumption of a realtime table")
public Response pauseConsumption(
@ApiParam(value = "Name of the table", required = true)
@PathParam("tableName") String tableName,
+ @ApiParam(value = "Comment on pausing the consumption")
@QueryParam("comment") String comment,
Review Comment:
Let us make it mandatory after one release then. In any reasonable
production instance, it is always best practice to leave comments when service
is affected due to manual action. The comment can then be imported into
alerting or other mechanisms that admins may build over Pinot.
please create an issue, keep track of it, and fix it when the next release
is completed.
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
