sajjad-moradi commented on code in PR #13803:
URL: https://github.com/apache/pinot/pull/13803#discussion_r1717878800
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PauseStatus.java:
##########
@@ -22,20 +22,27 @@
import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.annotation.JsonProperty;
import java.util.Set;
+import org.apache.pinot.spi.config.table.TablePauseStatus;
@JsonInclude(JsonInclude.Include.NON_NULL)
public class PauseStatus {
private boolean _pauseFlag;
private Set<String> _consumingSegments;
+ private TablePauseStatus.ReasonCode _reasonCode;
+ private String _comment;
private String _description;
Review Comment:
1. What existing use case?! PauseStatus is a brand new field.
3. Let's not complicate it, and remove it. We already have a pauseStatus
endpoint that is useful for progress report.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
