yashmayya commented on code in PR #13711:
URL: https://github.com/apache/pinot/pull/13711#discussion_r1717019101
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java:
##########
@@ -704,6 +704,97 @@ public void testVariadicFunction() throws Exception {
assertEquals(jsonNode.get("numRowsResultSet").asInt(), 3);
}
+ @Test
+ public void testPolymorphicScalarComparisonFunctions() throws Exception {
+ // Queries written this way will trigger the PinotEvaluateLiteralRule
which will call the scalar equals function
Review Comment:
Nope, in such queries the filter is simply removed even before any
optimization rules are applied in this part of the `SqlToRelConverter` -
https://github.com/apache/pinot/blob/14e51e87b8334b7fbcc5b3dfe67a7061710c5279/pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java#L294
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
