yashmayya commented on code in PR #13711:
URL: https://github.com/apache/pinot/pull/13711#discussion_r1696969801
##########
pinot-core/src/main/java/org/apache/pinot/core/query/postaggregation/PostAggregationFunction.java:
##########
@@ -38,20 +37,20 @@ public class PostAggregationFunction {
public PostAggregationFunction(String functionName, ColumnDataType[]
argumentTypes) {
String canonicalName = FunctionRegistry.canonicalize(functionName);
- FunctionInfo functionInfo =
FunctionRegistry.lookupFunctionInfo(canonicalName, argumentTypes);
+ int numArguments = argumentTypes.length;
+ FunctionInfo functionInfo =
FunctionRegistry.lookupFunctionInfo(canonicalName, numArguments);
Review Comment:
This doesn't seem to be an issue in the v2 engine where Calcite will ensure
the matching argument types during query compilation itself. And this
`PostAggregationFunction` seems to be the only v1 engine specific piece that
was updated in https://github.com/apache/pinot/pull/13573 to use the function
lookup by argument type. In case we want to be extra safe though, we could do
this - https://github.com/apache/pinot/pull/13711#issuecomment-2258300426.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
