ege-st commented on code in PR #13537:
URL: https://github.com/apache/pinot/pull/13537#discussion_r1674567745
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotHelixTaskResourceManager.java:
##########
@@ -317,8 +317,10 @@ public synchronized String submitTask(String
parentTaskName, List<PinotTaskConfi
public synchronized Set<String> getTasks(String taskType) {
String helixJobQueueName = getHelixJobQueueName(taskType);
WorkflowConfig workflowConfig =
_taskDriver.getWorkflowConfig(helixJobQueueName);
- Preconditions.checkArgument(workflowConfig != null, "Task queue: %s for
task type: %s does not exist",
- helixJobQueueName, taskType);
+ if (workflowConfig == null) {
+ LOGGER.error("Task queue: {} for task type: {} does not exist",
helixJobQueueName, taskType);
Review Comment:
Yeah, I don't think it's possible to check if a task is valid, I'm pretty
sure they can be dynamically defined (e.g. when Minion creates tasks). So I
task type could be valid and not yet have a queue. But it could also never have
a queue because no part of the system creates a task with the given type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
